Skip to content

Conversation

@nabuskey
Copy link
Collaborator

🔄 Pull Request

📝 Description

Background

The config file path was hardcoded as "config.yaml" in main.py, making it difficult to use different configurations for different environments or deployments.

Changes

• Added command line argument support: --config / -c
• Added environment variable support: SHS_MCP_CONFIG
• Updated README with configuration options

Usage

# Command line
python main.py --config /path/to/prod-config.yaml

# Environment variable
SHS_MCP_CONFIG=/path/to/staging-config.yaml python main.py

Priority: CLI argument > environment variable > default

🎯 Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 📖 Documentation update
  • 🧪 Test improvement
  • 🔧 Refactoring (no functional changes)

🧪 Testing

  • ✅ All existing tests pass (task test)
  • 🔬 Tested with MCP Inspector
  • 📊 Tested with sample Spark data
  • 🚀 Tested with real Spark History Server (if applicable)

fixes: #112

@nabuskey nabuskey mentioned this pull request Sep 18, 2025
15 tasks
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ef5f6a8 into kubeflow:main Sep 18, 2025
6 checks passed
@nabuskey nabuskey deleted the config-path branch September 18, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue when adding this MCP server in Cursor

2 participants